Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven wrapper and utf-8 standard encoding #206

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jannickherrmann
Copy link
Contributor

@jannickherrmann jannickherrmann commented Jun 17, 2024

Motivation

To ensure platform independence for Maven builds and to align with best practices for encoding standards.

Relates to: #205

What

Added Maven wrapper and set UTF-8 as default encoding.

Why

To make the build process more consistent across different platforms and to avoid encoding-related issues.

How

  • Added Maven wrapper files (mvnw, mvnw.cmd, .mvn/wrapper/)
  • Configured Maven to use UTF-8 encoding by default (<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> in pom.xml)

Verification Steps

  1. Clone the repository.
  2. Navigate to the project directory.
  3. Verify that the Maven wrapper files (mvnw, mvnw.cmd) are present.
  4. Open pom.xml and confirm <project.build.sourceEncoding> is set to UTF-8.
  5. Run a build using the Maven wrapper (./mvnw clean install) and ensure the build completes successfully on different platforms (Windows, macOS, Linux) and no warning appeared for source encodig.

Checklist:

  • Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task

Additional Notes

No additional notes.

@jannickherrmann jannickherrmann changed the title Feature/maven wrapper Add maven wrapper and utf-8 standard encoding Jun 18, 2024
@pb82
Copy link
Contributor

pb82 commented Jul 8, 2024

@jannickherrmann thanks, I can confirm that the wrapper works (after marking the script as executable)

@jannickherrmann
Copy link
Contributor Author

@pb82 thanks for the comment, i made the wrapper for unix/mac systems executable by default and pushed it. works on windows maschines

@alexted
Copy link

alexted commented Nov 7, 2024

@jannickherrmann Is this PR still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants